Repository navigation
Block eviction completion while Placement usage remains - #389
Merged
Merged
Conversation
fwiesel
force-pushed
the
placement-eviction-guard
branch
5 times, most recently
from
November 11, 2026 13:48
156f90b to
a11f58a
Compare
Closed
fwiesel
force-pushed
the
placement-eviction-guard
branch
from
November 11, 2026 13:55
a11f58a to
752bfd5
Compare
fwiesel
force-pushed
the
placement-eviction-guard
branch
from
November 13, 2026 10:00
752bfd5 to
563a347
Compare
The hypervisor server list can be empty before the source agent has finished a migration. Check the host's Placement usage and keep Evicting=True while any usage remains. Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
fwiesel
force-pushed
the
placement-eviction-guard
branch
from
November 13, 2026 16:30
563a347 to
22e8032
Compare
Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage detailsCompared to commit cfee313 (run #43438290245)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files:
|
fwiesel
marked this pull request as ready for review
November 16, 2026 08:47
mchristianl
approved these changes
Nov 16, 2026
PhilippMatthes
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eviction controller could report completion as soon as the hypervisor's server list was empty. A source live-migration or resize reservation can remain in Placement until finalization, so the source agent could be removed too early.
Check the host's Placement usage before setting
Evicting=False. Keep the eviction running while any usage remains, and fail closed when Placement cannot be queried. The existing infiniteConfirmResizeretry is unchanged.Tests cover the usage check and the eviction guard.